remove MaybeUninit::uninit_array
#134585
Merged
remove MaybeUninit::uninit_array
#134585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
LGTM. Just to make sure though that the plan is still current, let me reassign this to T-libs-API |
rustbot
added
the
T-libs-api
|
☔ The latest upstream changes (presumably #135402) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
has-merge-commits
This comment has been minimized.
This comment has been minimized.
rustbot
removed
has-merge-commits
|
☔ The latest upstream changes (presumably #137046) made this pull request unmergeable. Please resolve the merge conflicts. |
cyrgani
force-pushed
the
uninit_array
branch
2 times, most recently
from
1e40183 to
09e49ed
Compare
cyrgani
force-pushed
the
uninit_array
branch
from
09e49ed to
f0a6af0
Compare
|
r? libs-api |
|
I support the removal here. This was added because we didn't have |
RalfJung
added
the
I-libs-api-nominated
|
We already approved this removal, so this is fine. @bors r+ |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Feb 26, 2025
remove `MaybeUninit::uninit_array` Closes rust-lang#134584. Closes rust-lang#66845. The future of this unstable method was described in rust-lang#125082 (comment). Since `inline_const` was stabilized in 1.79 (4 stable releases away) and no one expressed interest for keeping it in rust-lang#96097, I think it can be removed now as it is not a stable method.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#136457 (Expose algebraic floating point intrinsics) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup of 10 pull requests Successful merges: - rust-lang#134585 (remove `MaybeUninit::uninit_array`) - rust-lang#136187 (Use less CString in the examples of CStr.) - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`) - rust-lang#137620 (Fix `attr` cast for espidf) - rust-lang#137631 (Avoid collecting associated types for undefined trait) - rust-lang#137635 (Don't suggest constraining unstable associated types) - rust-lang#137642 (Rustc dev guide subtree update) - rust-lang#137660 (Update gcc submodule) - rust-lang#137670 (revert accidental change in get_closest_merge_commit) - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 26, 2025
Rollup merge of rust-lang#134585 - cyrgani:uninit_array, r=Amanieu remove `MaybeUninit::uninit_array` Closes rust-lang#134584. Closes rust-lang#66845. The future of this unstable method was described in rust-lang#125082 (comment). Since `inline_const` was stabilized in 1.79 (4 stable releases away) and no one expressed interest for keeping it in rust-lang#96097, I think it can be removed now as it is not a stable method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134584.
Closes #66845.
The future of this unstable method was described in #125082 (comment). Since
inline_constwas stabilized in 1.79 (4 stable releases away) and no one expressed interest for keeping it in #96097, I think it can be removed now as it is not a stable method.