fix serving custom CSS coming from --extend-css in rustdoc #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jun 21, 2024
|
I thought this case was handled already. Good catch! |
github-actions
bot
added
S-waiting-on-deploy
|
Thanks for the quick fix everyone! One quick question/request...is there a way to manually trigger a re-build of the current docs for a release, or will I need to just up the version number and republish to take advantage of this fix? |
|
It's actually option 3 : We still only manually deploy docs.rs, which is why we have this "waiting for deploy" label. I'll probably do a deploy tomorrow or the day after, then everything should directly be fine. |
|
Perfect, thanks again |
|
@hedgecrw the code is deployed, everything should work now, can you confirm? |
syphar
removed
the
S-waiting-on-deploy
|
I can confirm that everything now looks correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2524
The CSS content from
--extend-cssends up in atheme.cssin the rustdoc output.We have to serve these similar to invocation specific JS files.
I added a test testing for both custom JS & CSS files, also validated locally that the bug in #2524 is fixed