Fix invalid release link generation #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
Nemo157
reviewed
Feb 9, 2024
GuillaumeGomez
force-pushed
the
link-generation
branch
3 times, most recently
from
693a934 to
35fee22
Compare
|
CI passed. \o/ |
syphar
requested changes
Feb 14, 2024
There was a problem hiding this comment.
I'll do manual testing now,
but just from reading the code I would say this will drop the target from the version links when I'm on a non-default target, since now you don't use params.target at all any more.
Or am I missing something?
Example:
https://docs.rs/tokio_telegraf/0.5.0/i686-pc-windows-msvc/tokio_telegraf/index.html
In the version links in the dropdown we see the target name too.
|
I now ran a local build, and yes, the target is missing. Also there seems to be another issue: 
|
syphar
added
S-waiting-on-author
|
Good point. I'll add a test for that as well, thanks! |
GuillaumeGomez
force-pushed
the
link-generation
branch
from
35fee22 to
e94aef1
Compare
GuillaumeGomez
force-pushed
the
link-generation
branch
from
e94aef1 to
4f9ea9f
Compare
|
Extended/fixed test and fixed code as well. |
github-actions
bot
added
S-waiting-on-review
syphar
approved these changes
Feb 16, 2024
syphar
approved these changes
Feb 16, 2024
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2411.
Sorry in advance for the noise but for some reason I can't run DB migrations locally so I can't run tests. I'll use the CI to check that I did correctly.