Skip to content

Commit

Permalink
update some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
syphar committed Jun 23, 2024
1 parent d6ae29d commit 34981d9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/web/crate_details.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,9 +504,9 @@ pub(crate) async fn get_all_releases(
.into_canonical_req_version_or_else(|_| AxumNope::VersionNotFound)?;

if matched_release.build_status() != BuildStatus::Success {
// this handler should only be used for successful builds, so then we have all rows in the
// This handler should only be used for successful builds, so then we have all rows in the
// `releases` table filled with data.
// If we at some point need this view for in-progress releases or failed releases, we need
// If we need this view at some point for in-progress releases or failed releases, we need
// to handle empty doc targets.
return Err(AxumNope::CrateNotFound);
}
Expand Down Expand Up @@ -640,8 +640,8 @@ pub(crate) async fn get_all_platforms_inner(
|| krate.default_target.is_none()
|| matched_release.target_name().is_none()
{
// FIXME: is this really OK? just return an empty platform list in case of
// an early failure?
// when the build wasn't finished, we don't have any target platforms
// we could read from.
return Ok(PlatformList {
metadata: ShortMetadata {
name: params.name,
Expand Down

0 comments on commit 34981d9

Please sign in to comment.