feat: allow other credential helpers in Finch VM #1265
Merged
+85
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
from
a629443 to
b25b3a2
Compare
pendo324
reviewed
Jan 31, 2025
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
2 times, most recently
from
8033a33 to
0a0f518
Compare
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
from
0a0f518 to
2da5dcd
Compare
swagatbora90
reviewed
Feb 1, 2025
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
4 times, most recently
from
484c1a9 to
860e92e
Compare
pendo324
previously approved these changes
Feb 3, 2025
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
from
860e92e to
19b2511
Compare
Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
allow-other-credential-helpers
branch
from
19b2511 to
360785d
Compare
pendo324
approved these changes
Feb 4, 2025
swagatbora90
approved these changes
Feb 4, 2025
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Addresses #800
Description of changes:
This change updates nerdctl commands to have other credential helpers on the path for nerdctl commands.
Testing done:
creds_helpers: - "ecr-login"to_output/config.yaml/usr/local/binLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.