Add ToB Death Sound Plugin #7887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casual plugin that makes a custom sound whenever the player or a teammate dies within Theatre of Blood. Currently the plugin only has 3 custom sounds, one being an inside joke amongst friends. I'm very new to coding so if there's a lot of mistakes, I apologize!!!!
Adds a plugin that plays a custom sound when a nearby player dies during the Theatre of Blood raid. - Works only inside ToB (region ID check) - Includes volume slider, enable/disable toggle, and sound selector - Sounds included: sitstella.wav, zerk.wav, sports.wav Author: Nic
Changed file names to be read by CI, apologies for the redundancy
Updated again to previous file extensions with decapitalization
New commit in my own Repo
CI and syntax fixes
Hopefully I did this right, got a really bad case of covid right now so feeling a little foggy so apologies in advance for any bulk of mistakes
|
Please avoid closing/recreating PRs; simply keep pushing to a single PR. Also your submission does not adhere to the described format in https://github.com/runelite/plugin-hub?tab=readme-ov-file#submitting-a-plugin as was pointed out in #7877 (comment) |
iProdigy
added
the
waiting for author
Format fix
runelite-github-app
bot
removed
the
waiting for author
|
New plugin |
Format fix AGAIN
|
Your repo structure is also invalid; I'd recommend emulating https://github.com/runelite/example-plugin/ |
iProdigy
added
the
waiting for author
Updated hash
runelite-github-app
bot
removed
the
waiting for author
Display Name Fix
Removed Override
Added LICENSE
|
Internal use only: Reviewer details Maintainer details |
Fixed System.err
|
Use AudioPlayer instead of managing clips yourself |
LlemonDuck
added
the
waiting for author
Using AudioPlayer rather than Clip
runelite-github-app
bot
removed
the
waiting for author
Added 'runelite-client' in dependencies
reversed dependencies change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ToB Death Sound plugin: plays a sound when a player dies in Theatre of Blood.
I'm very new to this process and open to any feedback.
Plugin repo: https://github.com/nicellenburg/tobdeathsound