Skip to content

Create homeassistant #7765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

db1996
Copy link

@db1996 db1996 commented Apr 5, 2025

This is a home assistant integration to have farming patch information available in home assistant.

This allows you to send notifications to your phone if you're not playing the game to notify you of patches being ready etc.

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 5, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Apr 5, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Contributor

Use an injected OkHttpClient instead of manually handling the requests

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 7, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 7, 2025
@LlemonDuck
Copy link
Contributor

You can lean on the runelite farming plugin instead of cloning it all yourself by just reading config keys. Were you trying to do anything that wouldn't be covered by that?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 14, 2025
@db1996
Copy link
Author

db1996 commented Apr 14, 2025

All I really want to do, is sync the farming timers/birdhouses/farming contract to home assistant. The reason I did it this way is because I copied this from a different plugin that also uses the farming timer classes directly.

Specifically, I copied it from this plugin: https://runelite.net/plugin-hub/show/time-tracking-reminder

I was trying to find a way to read it from the tracking plugin directly but I could not really figure out how to do that. How exactly can I read the config from the timers plugin? If you could point me to an example or something that would be great! I don't mind getting rid of those copied dependencies at all, that was my intention at the start anyway

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Apr 14, 2025
@raiyni
Copy link
Member

raiyni commented Apr 16, 2025

She is referencing using the config manager to read the values store in config. Eg, on config change you could be checking keys for timetracking. with values of patch varbit:time

https://github.com/runelite/runelite/blob/ef89a30c48712d4f6446899d13c857b5e750a5c7/runelite-client/src/main/java/net/runelite/client/plugins/timetracking/farming/FarmingTracker.java#L131

If you enable debug mode for your client, you can see the config changes in your console. Or you can log them to console in config changed.

@raiyni raiyni added the waiting for author waiting for the pr author to make changes or respond to questions label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants