Improve performance of case contacts index action using pagination #6208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerman07
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
github-actions
bot
added
dependencies
Kerman07
force-pushed
the
improve-case-contacts-index-performance-with-pagination
branch
2 times, most recently
from
3f46463 to
076ef75
Compare
compwron
reviewed
Feb 3, 2025
| @@ -32,6 +32,7 @@ gem "net-pop" # needed for ruby upgrade to 3.1.0 https://www.ruby-lang.org/en/ne | |||
| gem "net-smtp", require: false # needed for ruby upgrade to 3.1.0 for some dang reason | |||
| gem "noticed" # Notifications | |||
| gem "oj" # faster JSON parsing 🍊 | |||
| gem "pagy" # pagination | |||
There was a problem hiding this comment.
gem seems legit, ok to add
https://rubygems.org/gems/pagy
https://github.com/ddnexus/pagy
|
This looks very promising! Please fix the tests in CI and then we will merge! :) |
Kerman07
force-pushed
the
improve-case-contacts-index-performance-with-pagination
branch
3 times, most recently
from
542533b to
db0ce5c
Compare
Kerman07
force-pushed
the
improve-case-contacts-index-performance-with-pagination
branch
from
db0ce5c to
bfc1d02
Compare
|
@compwron CI tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6201
What changed, and why?
Added pagination to the case contacts index action, that fixes a lot of the performance issues.
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Before:
After:
Feelings gif (optional)