-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails upgrade 7.0.8 to 7.1.0 #5478
Merged
compwron
merged 22 commits into
rubyforgood:main
from
sarvaiyanidhi:rails-upgrade-7.0.8-to-7.1.0
Jan 31, 2024
Merged
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
123c200
Update Rails version in Gemfile from 7.0.8 to 7.1.0
sarvaiyanidhi 6c2f97e
rails app:update and overrides code
sarvaiyanidhi 23befdf
fixture singular path warning fix, Nokogiri parsed_body method fix
sarvaiyanidhi c7b9f24
Fix for deprecation warning for Rails.application.secrets and preview…
sarvaiyanidhi 78bd955
Configuration changes related to Rails 7.1.0
sarvaiyanidhi 67204da
Changes for Nokogiri parsed_body to html to match expectation
sarvaiyanidhi 33edac1
Changes for DEPRECATION WARNING: Setting action_dispatch.show_except…
sarvaiyanidhi 49f45e8
Fixed failing spec
sarvaiyanidhi 097686a
Code changes to handle ActionView::Template::Error: Cannot get a sig…
sarvaiyanidhi 7749518
Ruby Standard fix
sarvaiyanidhi c6d07d8
Ruby Standard fix
sarvaiyanidhi d267aa9
Config changes to handle deprecation warining of supporting multiple …
sarvaiyanidhi 63e833a
Fixing rspec issue
sarvaiyanidhi 1d639db
Reverted deprecation warning changes for spec failing issue
sarvaiyanidhi 7577090
Changes for ActionMailer deprecation warning
sarvaiyanidhi d7b4b1f
Ruby Standard Fix
sarvaiyanidhi 5506197
Updated code to load defaults 7.1 and fix file load issue
sarvaiyanidhi 6e57ee4
Ruby Lint issue fix
sarvaiyanidhi 6d9e514
Merged main branch and fixed failing spec
sarvaiyanidhi 1a05d0d
Reverted preview_path to old code to check failing spec issue
sarvaiyanidhi 2f7ee4d
Reverted to actual code as specs were still failing with old code
sarvaiyanidhi 52b5a59
Fix for failing specs
sarvaiyanidhi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to remove rails_blob_path and update with url code to handle ActionView::Template::Error: Cannot get a signed_id for a new record error.
Referred this open issue - https://stackoverflow.com/questions/77201333/cannot-get-a-signed-id-for-a-new-record-with-url-for-after-attaching-pictur