Placement reports #4768
Placement reports #4768
Conversation
github-actions
bot
added
erb
ruby
|
nice gif xD |
|
@rae-stanton could you merge in main and fix linting, both standardrb and erb? |
rae-stanton
requested review from
compwron,
FireLemons and
littleforest
as code owners
|
Ok, I fixed some things on this ticket, I'm not 100% sure why some of the checks are failing right now, but everything is passing on my local for the changes I've made thus far. Let me know if there's something I may have missed though! @littleforest |
|
Try prefixing your commands with |
|
@rae-stanton could you merge or rebase in |
This adds the placement report CSV for the current casa organization with tests for the service object as well. This also adds the expected route on the reports page and a decorator to format the date within the CSV to look cleaner.
This updated the casa org association that allows placement service & spec to run as expected.
adjusted index file to fix linting issue and also adjusted service file for small rubocop fix.
This adds the placement report CSV for the current casa organization with tests for the service object as well. This also adds the expected route on the reports page and a decorator to format the date within the CSV to look cleaner.
adjusted index file to fix linting issue and also adjusted service file for small rubocop fix.
rae-stanton
force-pushed
the
csv-placements-4718
branch
from
fc36c3d to
fb56ced
Compare
This adds the suggested changes from Jeanine - removes `id` in controller to just reference the organization itself and got rid of some unnecessary code in the index and csv service file. Adjusted tests to reflect changes and moved the `let` statements into the `it` block instead.
|
Ok all changes have been made! It looks like the only not passing thing with spec checker is that it really wants me to have a controller test. If that's needed, I'm happy to write one up, otherwise, let me know if there's anything else! Thanks for all the help and feedback. @littleforest |
|
@rae-stanton it's okay to add the the controller to the list of tests to skip in the We should fix up that |
| @@ -0,0 +1,15 @@ | |||
| require "rails_helper" | |||
| require "factory_bot_rails" | |||
There was a problem hiding this comment.
You can remove this line.
This adds the placement reports controller to the list of skipped controller tests and adds a request spec.
This adds the placement report CSV for the current casa organization with tests for the service object as well. This also adds the expected route on the reports page and a decorator to format the date within the CSV to look cleaner. Please let me know if there is anything I may have missed or if something isn't 100% right! 😊😊
What github issue is this PR for, if any?
Resolves #4718
This was part of the new Placements epic!
What changed, and why?
This adds the ability to export placement data! Previously, this was not available as an option for the orgs.
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Tested to expect specific columns to render properly when the CSV is generated.
Screenshots please :)
Feelings gif~
What gif best describes your feeling working on this issue?
