Add new Rails/MailerPreviews cop
#686
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I'd love to have this! |
|
@koic this PR seems to have been missed, I'd still love to have it. Any chance you could review when you have time? Thanks! 🙏 |
fatkodima
force-pushed
the
mailer-previews
branch
from
7de7628 to
26cc1cd
Compare
|
Rebased. |
|
We gave this Rails/MailerPreviews cop a try in two different projects with RSpec and it worked perfectly for our use case. Great job @fatkodima! In combination with the following rspec snippet forgotten and broken previews would be a thing of the past :D Let me know if there's anything I can do to help get this PR merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
Currently, rails supports only single preview path: https://github.com/rails/rails/blob/af0733a8e7ceddf6b9128ad2aaf4f74c5b427c43/actionmailer/lib/action_mailer/railtie.rb#L28
In the future, this will change: rails/rails#31595
So I created
PreviewPathsconfig as an array.