-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vitest to 1.6.1 to address security vulnerability CVE-2025-24964 #1656
base: master
Are you sure you want to change the base?
Conversation
|
@@ -46,16 +46,16 @@ | |||
"compare-versions": "^4.1.3", | |||
"eslint": "^8.15.0", | |||
"puppeteer": "^9.1.1", | |||
"typescript": "^5.4.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorting things is admirable, but has the downside that it generates conflicts in other PRs, e.g. another PR I'm cherry-picking this on has removed the puppeteer dependency from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh whoops. This wasn't done manually/intentionally. I think it may just be yarn
appending the new version when the package was updated 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to simplify? I think we'd need some process that automatically does this as part of existing processes e.g. prettier
(yarn:format)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's probably a good idea as a matter of standardization. I'm happy to look in to this, but will probably submit a separate PR for this work just to keep the concerns separated.
Hopefully this one is fairly straight forward. Our security team got alerted on a vulnerability in the version of vitest used. More information here. This PR bumps the version of vitest to 1.6.1.