Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bevy's built-in scrolling #88

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Use Bevy's built-in scrolling #88

merged 1 commit into from
Jan 16, 2025

Conversation

rparrett
Copy link
Owner

Bevy 0.15 includes built-in support for UI scrolling.

This means that our own scrolling code, which was based on manipulating the absolute position of the content of the clipping container, can be simplified.

The separate clipping container still seems to be required, unfortunately.

@rparrett
Copy link
Owner Author

rparrett commented Jan 15, 2025

This needs to be rebased after #89 is merged.

Also, JustifyContent::FlexEnd is still providing utility, preventing a one-frame delay. I can't figure out a better workaround for that, so it needs to come back.

@rparrett rparrett marked this pull request as draft January 15, 2025 15:52
@rparrett
Copy link
Owner Author

rparrett commented Jan 15, 2025

This isn't really any simpler, but it does feel less slightly less janky.

@rparrett rparrett marked this pull request as ready for review January 15, 2025 20:35
@rparrett rparrett merged commit c4a1d98 into main Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant