Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 📝 update the README file #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lwjohnst86
Copy link
Member

Description

Updates the README text of the repo.

Closes #41

This PR needs an in-depth review.

Checklist

  • Formatted Markdown

Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Just some minor suggestions :)

GitHub is increasingly used as a platform for collaborating and sharing
research projects, not only for code but for documents. This workshop
aims to introduce participants to the basics of using GitHub for
collaboration and version control. The workshop is designed for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it collaboration though with no branching and PRs/reviews? Is the collaboration referring to commenting on issues?

workshop administration files.
This repository mainly contains the workshop material that both the
participants and instructors use during the workshop. It also includes
files that build support building the website as well as configurations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
files that build support building the website as well as configurations
files that support building the website as well as configurations

TODO: Very brief intro, motivation, and overview of workshop.
GitHub is increasingly used as a platform for collaborating and sharing
research projects, not only for code but for documents. This workshop
aims to introduce participants to the basics of using GitHub for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section the word “participants” is used, while in the latter sections it’s “learners”. Should this be aligned?

The material in this workshop is designed to be presented primarily with
a participatory live-"typing" approach. This involves an instructor
doing the tasks on screen live in front of the learners, while the
learners follow along using their own computers. Activities to support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
learners follow along using their own computers. Activities to support
learners follow along by doing the tasks on their own computers. Activities to support

learners follow along using their own computers. Activities to support
learning are interspersed throughout the workshop material, allowing
participants to discuss with their neighbours or work on smaller
problems for a few minutes to reinforce learning. All material are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
problems for a few minutes to reinforce learning. All material are
problems to reinforce learning. All material are

The exercises are (at least set to be) more than a few minutes :)

repository:

- `index.Rmd`: Contains the overview of the workshop. This is the
landing page for the website.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
landing page for the website.
landing page of the website.

(e.g. code-along material).
- `appendix/` folder: Contains the files used to support the workshop,
such as resources and instructions for instructors.
- `slides/`: The presentation slides used for the workshop.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `slides/`: The presentation slides used for the workshop.
- `slides/`: Contains the presentation slides used for the workshop.

your own would be the slides, however, they are also good enough to use
on their own too.
The workshop is largely designed to be taught in the order given, as
each session builds off of the previous ones. The easiest way to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
each session builds off of the previous ones. The easiest way to use
each session builds off of the previous one(s). The easiest way to use

Comment on lines +67 to +68
to make as your own would be the slides, however, they are also good
enough to use on their own too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to make as your own would be the slides, however, they are also good
enough to use on their own too.
to make as your own would be the slides, however, they can also
be used on their own.


But if you want to customize a bit more, the best approach is to [fork
the repository](TODO) into your own GitLab account and modify it to fit your
But if you want to customize a bit more, the best approach is to fork
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
But if you want to customize a bit more, the best approach is to fork
If you want to customize the content a bit more, the best approach is to fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Update README
2 participants