Refactor updateQuality method and add more tests #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the two tests for the updateQuality function in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
-Add a new test that checks if the quality of an item is never negative. -Add tests that check if the quality for Aged Brie or Backstage Passes can be above 50. -Add tests that check if the quality increases for Aged Brie and Backstage Pass items as the SellIn value approaches. -Add test that checks if the quality for the Backstage Passes drops to 0 after the concert -Add test that checks if the quality of Sulfuras is 80 and never alters -Add test that checks if the SellIn date for Sulfuras never alters -Add test that checks if the SellIn value decreases by 1 for all items except Sulfuras -Correct test that checks if the SellIn date decreases for items except Sulfuras -Add 2 more items to the tests that check if the quality Of Backstage Passes increases -Check if the quality is not above 50 using only one test -Add test that checks if the quality degrades twice as fast once the SellIn date has passed -Add tests for conjured items -Check SellIn and Quality in the test for Backstage Passes Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Format code in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Modified updateQuality method in the gilded-rose.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Change test for the Suflura item in the gilded-rose.spec.ts file: fix the name of the item. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Modify updateQuality method in the gilded-rose.ts file Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Change test for Conjured items in the gilded-rose.spec.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Modify the updateQuality method in the gilded-rose.ts file. Signed-off-by: Alexandra Stroiu <alexandra.stroiu@stud.acs.upb.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor updateQuality method in the gilded-rose.ts file and add more tests in the gilded-rose.spec.ts file.