Update to dependency-check-core 12.1.0 & support datafeed downloads #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users need to use 12.1.0 due to [1]. However, this change means that the minimum java version is now 11, as dependency-check dropped support for java 8 in 11.0.0[2]. This upgrade also means that users will have to provide an NVD api-key[3]. So this is a pretty significant upgrade. [1]: dependency-check/DependencyCheck#7406 [2]: https://github.com/dependency-check/DependencyCheck?tab=readme-ov-file#breaking-changes-in-1100 [3]: https://github.com/dependency-check/DependencyCheck?tab=readme-ov-file#mandatory-upgrade-notice
This Downloader instance is used when a datafeed[1] URL is provided, but will throw an NPE if it isn't configured[2]. [1]: https://github.com/rm-hull/nvd-clojure?tab=readme-ov-file#configuration-options [2]: rm-hull#182
2 tasks
tobias
added a commit
to clojars/clojars-web
that referenced
this pull request
Feb 24, 2025
This upgrades to a version of nvd-clojure that will work correctly with the latest NVD database. It also updates to use a datafeed that provides a cached version of the database[1] that is much faster to download than pulling all of the updates from the NVD API directly. This upgrade also means we have to provide an NVD_API_TOKEN[2] to use the NVD api. This uses a fork[3] of nvd-clojure, as the upstream project does not yet support dependency-check-core 12.1.0 with datafeeds[4]. [1]: https://dependency-check.github.io/DependencyCheck_Builder/nvd_cache/ [2]: https://nvd.nist.gov/developers/request-an-api-key [3]: https://github.com/tobias/nvd-clojure/ [4]: rm-hull/nvd-clojure#183
|
This works for me. Thank you @tobias! |
remvee
added a commit
to jomco/nvd-clojure-action
that referenced
this pull request
Feb 28, 2025
See also: rm-hull/nvd-clojure#183
remvee
pushed a commit
to Basic-Data-Infrastructure/demo-vertrouwde-goederenafgifte
that referenced
this pull request
Feb 28, 2025
remvee
pushed a commit
to Basic-Data-Infrastructure/demo-vertrouwde-goederenafgifte
that referenced
this pull request
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to dependency-check-core 12.1.0
Users need to use 12.1.0 due to 1. However, this change means that the
minimum java version is now 11, as dependency-check dropped support for
java 8 in 11.0.02. This upgrade also means that users will have to
provide an NVD api-key3. So this is a pretty significant upgrade.
Configure singleton Downloader
This Downloader instance is used when a datafeed1 URL is provided, but
will throw an NPE if it isn't configured2.