Update bracket_test.py | Check auf fehlende global.ini #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenn keine global.ini vorhanden ist, soll der Test übersprungen werden.
rjcncpt
added
Verbesserung
MaxM1211
previously requested changes
Feb 10, 2025
With --github the output is formatted for github actions
greluc
previously approved these changes
Feb 22, 2025
| "ea_ui_player_count_bracket_right", | ||
| "input_key_keyboard_leftParenthesis,P", | ||
| "input_key_keyboard_rightParenthesis,P", | ||
| "hurston_intro_desc", # Aufzählung |
There was a problem hiding this comment.
Damit wir wissen warum es ignoriert wird.
.github/tests/bracket_test.py
Outdated
|
|
||
|
|
||
| def check_brackets(filename, excluded): | ||
| """ | ||
| :param filename: The name of the file to check for bracket matching. | ||
| :param excluded: A list of line numbers to exclude from checking. | ||
| :param excluded: A list of keys to exclude from checking. | ||
| :return: None | ||
|
|
||
| The check_brackets method reads the contents of the given file and checks for matching brackets. It skips the lines specified in the 'excluded' parameter. If any mismatched or unclosed |
There was a problem hiding this comment.
Kommentar noch ggf. anpassen, dass es "lines skipped" deren keys ausgeschlossen sind.
greluc
added
Geprüft
|
@rjcncpt Wenn das gemerged ist kannst dann die fehlerhaften Zeilen anpassen, sodass es wieder alles passt ;-) Das passt ja nicht zu diesem PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wenn keine global.ini vorhanden ist, soll der Test übersprungen werden.