Add grace and arpeggios notes to the timemap #3956
Conversation
|
I am presuming that grace notes are given a non-zero duration in the MIDI file? Otherwise there can be problems with MIDI playback. |
|
That makes me wonder if this would be a chance to add support for |
I can add it for |
|
Having it for |
|
|
|
Good enough 😛 |
lpugin
changed the title
|
Should be good to merge |
include/vrv/vrvdef.h
Outdated
| @@ -73,6 +73,7 @@ namespace vrv { | |||
| #define MIDI_TEMPO 120 | |||
|
|
|||
| #define UNACC_GRACENOTE_DUR 27 // in milliseconds | |||
| #define UNACC_GRACENOTE_FRACTION Fraction(1, 2024) | |||
There was a problem hiding this comment.
Is 2024 correct? 1024 or 2048 would make more sense?
This PR adds the grace notes to the timemap. Fixes #3909
A new functor has been added to do the gracenotes adjustment when preparing the timemap instead of doing it when producing the MIDI. The MIDI output is simplified and uses the timemap values.
Marked as draft for now since I will do the same for arpeggios and tablature note extension.
MEI
Timemap
[ { "on": [ "no43wyy" ], "qstamp": 0, "tempo": 120, "tstamp": 0 }, { "off": [ "no43wyy" ], "on": [ "n12ubxu0" ], "qstamp": 1, "tstamp": 500 }, { "off": [ "n12ubxu0" ], "on": [ "n1bor2nx" ], "qstamp": 2, "tstamp": 1000 }, { "off": [ "n1bor2nx" ], "on": [ "nwfmhjk" ], "qstamp": 2.5, "tstamp": 1250 }, { "off": [ "nwfmhjk" ], "on": [ "nqu5764" ], "qstamp": 3, "tstamp": 1500 }, { "off": [ "nqu5764" ], "on": [ "n1omecu9" ], "qstamp": 3.5, "tstamp": 1750 }, { "off": [ "n1omecu9" ], "on": [ "nddv0ri" ], "qstamp": 4, "tstamp": 2000 }, { "off": [ "nddv0ri" ], "on": [ "nddv0ri" ], "qstamp": 4.25, "tstamp": 2125 }, { "off": [ "nddv0ri" ], "on": [ "n1wugmch" ], "qstamp": 4.5, "tstamp": 2250 }, { "off": [ "n1wugmch" ], "on": [ "n3838hl" ], "qstamp": 5, "tstamp": 2500 }, { "off": [ "n3838hl" ], "on": [ "n1f2gd5u" ], "qstamp": 5.5, "tstamp": 2750 }, { "off": [ "n1f2gd5u" ], "on": [ "n1vifptt" ], "qstamp": 6, "tstamp": 3000 }, { "off": [ "n1vifptt" ], "on": [ "ntm0bnk" ], "qstamp": 7, "tstamp": 3500 }, { "off": [ "ntm0bnk" ], "on": [ "nk6zpsf" ], "qstamp": 8, "tstamp": 4000 }, { "off": [ "nk6zpsf" ], "on": [ "rorcdtg" ], "qstamp": 8.5, "tstamp": 4250 }, { "on": [ "n12lfalk" ], "qstamp": 8.984375, "tstamp": 4492 }, { "off": [ "rorcdtg", "n12lfalk" ], "on": [ "nrs4lhq" ], "qstamp": 9, "tstamp": 4500 }, { "on": [ "n18wlm3l" ], "qstamp": 9.984375, "tstamp": 4992 }, { "off": [ "nrs4lhq", "n18wlm3l" ], "on": [ "n1jy649" ], "qstamp": 10, "tstamp": 5000 }, { "off": [ "n1jy649" ], "on": [ "n19c8hp6" ], "qstamp": 11, "tstamp": 5500 }, { "off": [ "n19c8hp6" ], "on": [ "nwp1uti" ], "qstamp": 11.5, "tstamp": 5750 }, { "off": [ "nwp1uti" ], "on": [ "n1w0ysrk" ], "qstamp": 12, "tstamp": 6000 }, { "off": [ "n1w0ysrk" ], "on": [ "n1u30b27" ], "qstamp": 12.5, "tstamp": 6250 }, { "off": [ "n1u30b27" ], "on": [ "n1pe3h1n" ], "qstamp": 13, "tstamp": 6500 }, { "off": [ "n1pe3h1n" ], "on": [ "n12jrufd" ], "qstamp": 13.16666666666667, "tstamp": 6583 }, { "off": [ "n12jrufd" ], "on": [ "nuliurc" ], "qstamp": 13.33333333333333, "tstamp": 6667 }, { "off": [ "nuliurc" ], "on": [ "nfs0gck" ], "qstamp": 13.5, "tstamp": 6750 }, { "off": [ "nfs0gck" ], "on": [ "ndd650g" ], "qstamp": 14, "tstamp": 7000 }, { "off": [ "ndd650g" ], "on": [ "n4l117g" ], "qstamp": 14.0625, "tstamp": 7031 }, { "off": [ "n4l117g" ], "on": [ "ncuq7yy" ], "qstamp": 14.125, "tstamp": 7063 }, { "off": [ "ncuq7yy" ], "on": [ "neh1osz" ], "qstamp": 14.1875, "tstamp": 7094 }, { "off": [ "neh1osz" ], "on": [ "noto51m" ], "qstamp": 14.25, "tstamp": 7125 }, { "off": [ "noto51m" ], "on": [ "nc7avtd" ], "qstamp": 14.3125, "tstamp": 7156 }, { "off": [ "nc7avtd" ], "on": [ "nloeqsd" ], "qstamp": 14.375, "tstamp": 7188 }, { "off": [ "nloeqsd" ], "on": [ "n7nve8j" ], "qstamp": 14.4375, "tstamp": 7219 }, { "off": [ "n7nve8j" ], "on": [ "nljpcte" ], "qstamp": 14.5, "tstamp": 7250 }, { "off": [ "nljpcte" ], "on": [ "nrwsesl" ], "qstamp": 14.5625, "tstamp": 7281 }, { "off": [ "nrwsesl" ], "on": [ "n14a1l9r" ], "qstamp": 14.625, "tstamp": 7313 }, { "off": [ "n14a1l9r" ], "on": [ "ngzg16q" ], "qstamp": 14.6875, "tstamp": 7344 }, { "off": [ "ngzg16q" ], "on": [ "n1ua9fxl" ], "qstamp": 14.75, "tstamp": 7375 }, { "off": [ "n1ua9fxl" ], "on": [ "n1f0x1st" ], "qstamp": 14.8125, "tstamp": 7406 }, { "off": [ "n1f0x1st" ], "on": [ "ntxenxm" ], "qstamp": 14.875, "tstamp": 7438 }, { "off": [ "ntxenxm" ], "on": [ "n12egnpa" ], "qstamp": 14.9375, "tstamp": 7469 }, { "off": [ "n12egnpa" ], "on": [ "n11pynnw" ], "qstamp": 15, "tstamp": 7500 }, { "off": [ "n11pynnw" ], "qstamp": 16, "tstamp": 8000 } ]Example use of the timemap with grace note highlighting (new)
Screen.Recording.2025-02-16.at.11.49.02.mov