feat(SBC): Provision proto #20452
Merged
feat(SBC): Provision proto #20452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkbriar
reviewed
Feb 12, 2025
proto/sbc_provision.proto
Outdated
| string label = 1; | ||
| } | ||
|
|
||
| service NodeGroupController { |
There was a problem hiding this comment.
Shall we unify the term, such as ResourceGroupController?
@shanicky PTAL
There was a problem hiding this comment.
Do we plan to provision something other than node groups? If not we can also be precise and use NodeGroupController.
There was a problem hiding this comment.
I'm fine with both. Resource group is what's used in the kernel, while node group is from the operator. They do have a 1-1 mapping.
…o cajan93/sbc-proto
|
I will add the Proto-related changes in https://github.com/risingwavelabs/serverless-backfill-controller/pull/81 |
shanicky
approved these changes
Feb 16, 2025
proto/sbc_provision.proto
Outdated
| syntax = "proto3"; | ||
|
|
||
| // Provision a node via the serverless backfill controller. | ||
| package sbc; |
There was a problem hiding this comment.
Could you use a full name? Future colleagues might not immediately associate "sbc" with anything.
…o cajan93/sbc-proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Communication between kernel and the Serverless Backfill Controller (SBC). Proto definitions should be in this repo and not in the SBC repo.
Equivalent on SBC side: https://github.com/risingwavelabs/serverless-backfill-controller/pull/76
Checklist
Documentation
Release note