Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inst.text mode issues #6127

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

jkonecny12
Copy link
Member

Fix two bugs in the inst.text execution code:

  • RDP question is skipped because inst.text was detected as kickstart configuration (not really)
  • after answering text in the RDP question it will jump to GUI instead

When user add inst.text on the kernel command line then Anaconda should
ask question if user wants to use RDP or switch to the text mode.
However, this behavior was broken on Rawhide.

The issue was introduced by commit
55e0317
which was moving the display modes to runtime module. In this module,
the check for rdp was changed from kickstart data logic to cmdline
logic.
Issue was introduced by 4863cc6
which was refactoring the display code and missed one if.

Resolves: RHEL-77162
@github-actions github-actions bot added the f42 Fedora 42 label Jan 31, 2025
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@jkonecny12 jkonecny12 requested a review from M4rtinK January 31, 2025 15:46
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good as well. :)

@jkonecny12 jkonecny12 merged commit 8f41dd0 into rhinstaller:main Feb 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f42 Fedora 42
Development

Successfully merging this pull request may close these issues.

2 participants