Added missing in-battle "Move Info" button prompt #6155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Jan 31, 2025
|
Addressed review comments |
Bassoonian
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very late followup to #4860 (from 1.9.0, which is why I'm aiming this to
master)Unlike the "Last Ball" functionality, there was no prompt for the in-battle move descriptions, so this PR adds that, with both L and R versions for the graphics.
Because the last ball window's input doesn't directly conflict with the move description's, I removed the restriction of not being able to use the same button for both.
Images
L & R versions showcase
Issue(s) that this PR fixes
Closes #4677
People who collaborated with me in this PR
@TeamAquasHideout from who I got the source from and @BelialClover from who Archie got the source from.
Discord contact info
AsparagusEduardo