forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to Poké Flute and Town Map #5405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Sep 21, 2024
AlexOn1ine
reviewed
Sep 27, 2024
Bassoonian
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives the Poke Flute and the Town Map their functionality from FRLG.
The Poke Flute is an infinite use item that heals sleep of every pokemon in the party. If used in battle it also heals the sleep of every opponent's pokemon as well. Pokemon with the soundproof ability get ignored. The Town Map brings up a simple map of the region, the same as checking the map in pokemon centers.
For the Poke Flute it was a more straightforward port of frlg code. For the town map I used an implementation Lunos did, since FRLG has pretty different map code, and I don't want to mess up the regular pokenav map.
People who collaborated with me in this PR
@LOuroboros basically did the Town Map implementation.
Discord contact info
kittenchilly