Send to exact match only when notify in poller #537
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
+ Coverage 56.02% 56.09% +0.06%
==========================================
Files 129 129
Lines 13923 13928 +5
==========================================
+ Hits 7801 7813 +12
+ Misses 5659 5653 -6
+ Partials 463 462 -1 ☔ View full report in Codecov by Sentry. |
| @@ -305,6 +306,11 @@ func (w *PollWorker) Process(mesg *aio.Message) { | |||
| return | |||
| } | |||
|
|
|||
| if mesg.Type == message.Notify && conn.id != data.Id { | |||
| mesg.Done(false, fmt.Errorf("no connection found for group %s and id %s", data.Group, data.Id)) | |||
There was a problem hiding this comment.
Given that not being able to deliver a notify message is not an error in that our guarantee is "at most once", should we return success here?
There was a problem hiding this comment.
I was wondering the exact same thing!
The reason I went with an error is so that the sender subsystem could retry notify messages if we ever want to do an enqueue retry loop (but still go directly to completed on successful enqueue). I figure the poller in the sdk may lose and re-establish a connection from time to time so it is possible that at one moment there is no active connection and later there is where the sdk instance itself did not actually restart.
No description provided.