-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to upgrade the cluster via the new binary #684
feat: ability to upgrade the cluster via the new binary #684
Conversation
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
c777c7a
to
6e755df
Compare
5f911e5
to
cb074e7
Compare
1737f3d
to
a47ffba
Compare
a47ffba
to
7eb4543
Compare
@@ -30,15 +30,15 @@ jobs: | |||
|
|||
- name: Build and push local-artifact-mirror image | |||
run: | | |||
export SHORT_SHA=dev-$(git rev-parse --short=7 HEAD) | |||
export SHORT_SHA=dev-${GITHUB_SHA::7} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should match what's in the pull-request.yaml version of things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't use the same thing here though as github.event.pull_request.head.sha
doesn't apply here, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess we could use GITHUB_SHA
in pull-request.yaml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides the SHORT_SHA mismatch between pull-request.yaml and release-dev.yaml (we should really combine those soon)
No description provided.