feat(dr): new improved dr restore capability #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
emosbaugh
commented
Dec 6, 2024
| @@ -321,8 +322,8 @@ func RestoreCmd(ctx context.Context, name string) *cobra.Command { | |||
| backupToRestore = pickBackupToRestore(backups) | |||
|
|
|||
| logrus.Info("") | |||
| completionTimestamp := backupToRestore.Status.CompletionTimestamp.Time.Format("2006-01-02 15:04:05 UTC") | |||
| shouldRestore := prompts.New().Confirm(fmt.Sprintf("Restore from backup %q (%s)?", backupToRestore.Name, completionTimestamp), true) | |||
| creationTimestamp := backupToRestore.GetCreationTimestamp().Time.Format("2006-01-02 15:04:05 UTC") | |||
There was a problem hiding this comment.
Shouldnt this be creation timestamp not completion timestamp?
emosbaugh
force-pushed
the
emosbaugh/sc-116323/implement-app-specific-restore-capabilities
branch
from
a752b8c to
f539aa4
Compare
emosbaugh
force-pushed
the
emosbaugh/sc-116323/implement-app-specific-restore-capabilities
branch
from
850cb27 to
017d7e5
Compare
|
[sc-116990] |
sgalsaleh
reviewed
Dec 13, 2024
pkg/snapshots/backup.go
Outdated
There was a problem hiding this comment.
should the package name be dr or disasterrecovery instead? the term snapshots is for legacy backup/restore functionality.
sgalsaleh
previously approved these changes
Dec 13, 2024
JGAntunes
approved these changes
Dec 13, 2024
sgalsaleh
approved these changes
Dec 13, 2024
emosbaugh
deleted the
emosbaugh/sc-116323/implement-app-specific-restore-capabilities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for restoring from dual-backups.
Adds a new app release with a Restore resource for E2E tests.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?
TODO