-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing a design system page to showcase each components #245
Draft
BrianS111
wants to merge
157
commits into
develop
Choose a base branch
from
design-system-page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Profiles * `/` --> connect a wallet to see the connected wallet's profile page * `/u/(0xADDRESS|name.eth|handle.lens)` --> see the profile for `0xADDRESS` * Each card on the profile page: * Link to the profile site's home page (e.g. https://disco.xyz) * Link to the profile site's profile page (e.g. https://disco.xyz/0xAddress) * Launch receiver * NOTABLY ABSENT: Cards do not do any data fetching right now. Data fetching was trimmed to limit the scope of the v0 release. The data-fetching hooks and functions are still in the codebase, they just are piped into any cards at the moment. ## Conversations * `/conversations` --> connect a wallet and sign into XMTP to see your conversations * Each card on the conversations page: * Link to the card's Relay profile (relay.cc/u/0xAddress) * Launch receiver to 1:1 conversation
* /conversations also routes to convo list * add `display` prop to contact loading card
* On mobile, instead of the fade-in/fade-out behavior on hover, we just show the fadeIn component immediately.
* `/ `-> title is "Relay" * `/u/:handle` -> title is "handle"
* Upgrade @relaycc/receiver to 0.1.65 * Fix bug about undefined lens profiles
Update README.md
- Move social icons from header into footer
Still a few more components to go, build is broken currently because props on PinIcon.tsx |
2139ad1
to
52ee08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will showcase all of the components in the lib/design file as described in #221