docs: ALU: drop to keyword from polyfill names
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the LLVM IR instructions come in the form of just an opcode followed by operands, but some introduce an extra `to` keyword, e.g. `zext` is called as follows: ```llvm %X = zext i32 257 to i64 ``` As discussed in the compiler skeleton PR[1], this naming duality make the instructions-to-polyfills mapping more complex without adding any benefits. Remove the `to` keyword from polyfill names. Affected instructions: trunc, zext, sext, ptrtoint, inttoptr, bitcast. -- [1] #74 (comment) Signed-off-by: Wojciech Zmuda <zmuda.w@gmail.com>
2 tasks
iamrecursion
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of the LLVM IR instructions come in the form of just an opcode followed by operands, but some introduce an extra
tokeyword, e.g.zextis called as follows:Details
As discussed in the compiler skeleton PR, this naming duality make the instructions-to-polyfills mapping more complex without adding any benefits. Remove the
tokeyword from polyfill names. Affected instructions:trunc,zext,sext,ptrtoint,inttoptr,bitcast.Checklist
[ ] Code is formatted by Rustfmt.