Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add a case to the test for the iteration per second #359

Merged
merged 2 commits into from
May 3, 2024
Merged

ci: add a case to the test for the iteration per second #359

merged 2 commits into from
May 3, 2024

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented May 3, 2024 •
edited
Loading 

ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux]
Warming up --------------------------------------
      MGET: original   670.000 i/100ms
      MGET: emulated    99.000 i/100ms
    MGET: single_get    30.000 i/100ms
Calculating -------------------------------------
      MGET: original      6.880k (± 6.7%) i/s -     34.840k in   5.093497s
      MGET: emulated    984.077 (± 6.1%) i/s -      4.950k in   5.057650s
    MGET: single_get    317.817 (± 4.4%) i/s -      1.590k in   5.012359s

Comparison:
      MGET: original:     6880.2 i/s
      MGET: emulated:      984.1 i/s - 6.99x  slower
    MGET: single_get:      317.8 i/s - 21.65x  slower

supercaracal
supercaracal commented May 3, 2024
View reviewed changes
test/redis_client/test_cluster.rb
assert_equal(%w[WATCH MULTI SET SET EXEC], @captured_commands.to_a.map(&:command).map(&:first))

wait_for_replication
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  1) Failure:
RedisClient::TestCluster::ScaleReadLatency#test_transaction_does_not_pointlessly_unwatch_on_success [test/redis_client/test_cluster.rb:368]:
Expected: ["1", "2"]
  Actual: ["0", "0"]

@supercaracal supercaracal marked this pull request as ready for review May 3, 2024 22:31
@supercaracal supercaracal merged commit a13e363 into redis-rb:master May 3, 2024
27 checks passed
@supercaracal supercaracal deleted the ci-ips-mget branch May 3, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@supercaracal