Refactor key-slot conversion logic #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the above test case is failure. Also, we can ignore Rubocop errors at this time because they aren't related to this refactoring. |
Previously, extract_first_key would perform hashtag extraction on the key it pulled from command; that meant that the "key" it was returning might not actually be the key in the command. This commit refactors things so that * extract_first_key actually extracts the first key * KeySlotConverter.convert does hashtag extraction * Router's find_node_key and find_primary_node_key can now be implemented in terms of a function "find_node_by_key", because they _actually_ get the key from the command.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/keyslot_refactor
branch
from
c7464e7 to
31968f3
Compare
|
Apologies, I made a mistake while resolving conflicts from my cherry-pick. The test should be fixed now. |
supercaracal
approved these changes
Dec 12, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, extract_first_key would perform hashtag extraction on the key it pulled from command; that meant that the "key" it was returning might not actually be the key in the command.
This commit refactors things so that
This is helpful for the cluster transaction support work, because it means we can re-use the keyslot/hashtag logic for transaction node assignment.