Skip to content

refactor: use OSProcessStreamConnectionProvider #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

refactor: use OSProcessStreamConnectionProvider #1444

merged 1 commit into from
Apr 8, 2025

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Apr 7, 2025 •
edited
Loading

refactor: use OSProcessStreamConnectionProvider

@angelozerr
refactor: use OSProcessStreamConnectionProvider
26142a9 
Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr force-pushed the switch_to_OSProcessStreamConnectionProvider branch from 8b57a5f to 26142a9 Compare April 8, 2025 07:33
@angelozerr angelozerr changed the title refact: use OSProcessStreamConnectionProvider refactor: use OSProcessStreamConnectionProvider Apr 8, 2025
@angelozerr angelozerr self-assigned this Apr 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@angelozerr angelozerr added the enhancement New feature or request label Apr 8, 2025
@angelozerr angelozerr added this to the 2.1.1 milestone Apr 8, 2025
@angelozerr angelozerr merged commit c706d6b into redhat-developer:main Apr 8, 2025
5 of 13 checks passed
@angelozerr
Copy link
Contributor Author

angelozerr commented Apr 9, 2025 •
edited
Loading

@turkeylurkey @mrglavas I suggest that you switch also to OSProcessStreamConnectionProvider:

  • all plugins which are based on LSP4IJ, uses OSProcessStreamConnectionProvider
  • LSP4IJ uses OSProcessStreamConnectionProvider for https://github.com/redhat-developer/lsp4ij/blob/main/docs/UserDefinedLanguageServer.md and it seems it is working pretty well
  • OSProcessStreamConnectionProvider uses standard IntelliJ ProcessHandler
  • OSProcessStreamConnectionProvider have a better support to report errors and nice feature like when the process is killed outside the IntelliJ, the server status switch to stopped status.

If you switch to OSProcessStreamConnectionProvider and you have some trouble, please create issues.

This was referenced Apr 9, 2025
Closed
Merged
@mrglavas
Copy link

mrglavas commented Apr 9, 2025

If you switch to OSProcessStreamConnectionProvider and you have some trouble, please create issues.

@angelozerr Thanks. I'm trying it out here: OpenLiberty/liberty-tools-intellij#1323. Didn't run into any issues testing it manually. We'll see how our automation goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@angelozerr angelozerr

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @mrglavas