Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Tree Diff: small documentation to mention the file selector #12011

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 20, 2025

Briefly explanation about how to use visual doc diff.

Closes #12009


📚 Documentation previews 📚

Briefly explanation about how to use visual doc diff.

Closes #12009
@humitos humitos requested a review from a team as a code owner February 20, 2025 12:18
@humitos humitos requested a review from ericholscher February 20, 2025 12:18
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Once there, you can toggle it on/off by pressing the :guilabel:`Show diff` link from the UI element to show all the chunks and their differences highlighted with red/green background colors.
Besides, you can jump between each of these chunks by clinking on the up/down arrows.

All the available configuration for the visual diff addon can be found under :guilabel:`Settings > Addons > Visual diff` in the :term:`dashboard`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could link to this directly with a URL arg 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, I think Sphinx doesn't allow us to use guilabel with a link: https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-guilabel

Do we have an example of what you would like to render? BTW, the link where would point to? I suppose we would need something like "Choose organization" feature but for projects.


* **Tables** are shown to have changes when they may not have changed. This is due to do subtly in how HTML tables are rendered, and will be fixed in a future version.
* **Invisible changes** sometimes are marked as diff due than the underlying HTML changed, but there is no visual change. This could happen if the URL of a link changed, for example.
* **Chunks background is incorrect** when we are unable to detect the correct main parent element for the chunk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure what this is saying? Will the background be missing or smaller than expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we don't detect the immediate main parent element of the chunk, we keep going up to the parent of the parent and so on. It could happens that the highlighted node ends up being the whole document.

I tried to find a quick example, but I wasn't able to. However, I know this happens sometimes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we just shouldn't highlight in that case? Maybe limit parent looking to 2-3 elements and explicitly avoid things that look like content divs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we will fix this issue. I tried a few different stuffs already but none worked reliably.

I think it's fine to document it as a known bug/issue for now.

humitos and others added 3 commits February 20, 2025 17:20
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
Co-authored-by: Eric Holscher <25510+ericholscher@users.noreply.github.com>
@humitos humitos merged commit cdd9597 into main Feb 24, 2025
8 checks passed
@humitos humitos deleted the humitos/filetreediff-docs branch February 24, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Tree Diff: document the concepts
2 participants