Fix cover image resizing on Chrome browser #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2016 17:05
…% width; whereas on firefox, etc they take up 100% height. This leads to the cover image appearing correct on firefox; but on chrome the image takes up multiple columns (and thus appears to occupy several pages). This code change causes Chrome to size the images so that they are 100% height, not 100% width.
# Conflicts: # js/views/reflowable_view.js # readium-cfi-js
|
Hi, I am really interested in this problem. BTW, how did you get the cover page element? We have tried some methods but all failed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is Finalized
Related issue(s) and/or pull request(s)
See also #342
Test cases, sample files
Additional information
Please provide any and all information that might help us
On chrome browsers, the cover image takes up 100% width; whereas on firefox, etc they take up 100% height. This leads to the cover image appearing correct on firefox; but on chrome the image takes up multiple columns (and thus appears to occupy several pages). This code change causes Chrome to size the images so that they are 100% height, not 100% width.
This code is currently deployed in the Bibliotheca reader. This is certainly one way to fix the issue; there are other ways I'm sure.
Here is the markup from one of my ebooks that exhibits this behavior (view the comment's source to see the page source). The image is 467 x 700 px.