RDK-52204: Convert GDial as Library #114
Conversation
Reason for change: Convert GDial as Library, Later it will be used from XCast OutOfProcess Thunder plugin Test Procedure: GDial should be converted as library Risks: HIGH Priority: P0 Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
Copyright scan failureCommit: ceb45e1 |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/4b2c20414f3f9ae353b8722dee081256 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/80f631bee08f7ffc4f94a4a41edaf981 |
| gdialService *m_gdialService{nullptr}; | ||
| gdialServiceImpl *m_gdialServiceImpl{nullptr}; | ||
|
|
||
| static const char *dial_specification_copyright = "Copyright (c) 2017 Netflix, Inc. All rights reserved."; |
There was a problem hiding this comment.
Please add an extra phrase ", licensed under the BSD-2 license" to the copyright string.
There was a problem hiding this comment.
Ok sure
There was a problem hiding this comment.
Hi: I have been looking at this again, and the extra phrase is not needed. Netflix doesn't require anything extra. The license is not exactly BSD-2, and is available in NOTICE in any case. If the "Draft" status changes, please slack me to upvote.
|
Moving this PR into Draft as testing inprogress |
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
|
b'## Copyright scan failure |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/3f1d284aea96cae20088daf7cd57493a |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/79275aa6c79412a72aee2dbd75c71317 |
|
b'## Copyright scan failure |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/191dc9861aaf6579213b54a05efc4978 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/61cda0c412429d1a6cc926484e1a3329 |
yuvaramachandran-gurusamy
force-pushed
the
main_RDK-52204
branch
from
0be6a94 to
1164323
Compare
|
b'## Copyright scan failure |
yuvaramachandran-gurusamy
force-pushed
the
main_RDK-52204
branch
from
1164323 to
9454ba8
Compare
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/f930391d15c903deb1a112fe00d5c751 |
|
b'## Copyright scan failure |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/0cb7c26923ffea51b26ced94a06ee18a |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/0683fb4c73cd47a139ed9b181d8ad1d6 |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/15656aff742b60a323e526c5cfe9ca88 |
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
yuvaramachandran-gurusamy
force-pushed
the
main_RDK-52204
branch
from
9454ba8 to
0d1151f
Compare
|
b'## Copyright scan failure |
|
build-rpi4-ipstb-oss Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/ce7450b7ca9148e5df2f6b503c215c85 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a4117fb64053eaccbba0c4985f079bb5 |
RDK-52204: Convert GDial as Library
Reason for change: Convert GDial as Library, Later it will be used from XCast OutOfProcess Thunder plugin
Test Procedure: GDial should be converted as library
Risks: HIGH
Priority: P0
Signed-off-by: yuvaramachandran_gurusamy yuvaramachandran_gurusamy@comcast.com