-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from conda-build
to rattler-build
#374
Open
gforsyth
wants to merge
42
commits into
rapidsai:branch-0.43
Choose a base branch
from
gforsyth:rattler-build
base: branch-0.43
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+341
−316
Open
Changes from 35 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
fca047d
Switch from `conda-build` to `rattler-build`
gforsyth df73928
Make sure cmake is available on output host
gforsyth 58eaa03
Check package contents
gforsyth 2e83626
fix `rmm` pinning, add `make`, standardize quotes
gforsyth 2ef072f
Add build environment for ucxx output
gforsyth 0717789
Explicit cuda-cudart-dev version
gforsyth 25a0e70
pin cuda-version in examples host
gforsyth 73b4826
(HACK): force exact pinning in `env.yaml`
gforsyth f995245
force prepended channel name
gforsyth 952b2eb
revert to sequential solves
gforsyth e27f89a
Revert "revert to sequential solves"
gforsyth cca3956
Remove sed hacking (doesn't work anyway)
gforsyth d6d413f
don't prepend `cuda` to examples build string
gforsyth 1338b4e
add missing run exports to libucxx
gforsyth c4365d5
fix distributed-ucxx build string
gforsyth 170be1a
remove cuda-version from examples host
gforsyth d3e28c1
explicit build environments per output
gforsyth 7753854
ignore strict cuda-version pinning in examples
gforsyth 5744f54
explicit run ignore of `cuda-version`
gforsyth 4d2e89f
remove duplicate build env
gforsyth d6df972
ignore cuda run exports in distributed-ucxx
gforsyth fe45008
Restore `cmake` to tests output
gforsyth 9eb378b
explicit build env for ucxx
gforsyth 3f5e45f
standardize on ignoring `cuda-version` instead of `compiler('cuda')`
gforsyth bfa2734
Remove python dir cmake arg
gforsyth c59b00b
flip condition for cudart-dev
gforsyth 1037b03
Remove unneeded conda channel configuration
gforsyth 0fe315a
inline build.sh
gforsyth 238fb68
Generate noarch `distributed_ucxx`
gforsyth 1bf13d1
ignore run exports `cuda-cudart-dev`
gforsyth 25ee3d4
Don't specify `ignore_run_exports` for `noarch`
gforsyth 27b6260
ignore cudart export from cache-host
gforsyth 603a907
ignore exports from `ucx`, fix py version string
gforsyth 6a49743
disable non-conda workflows
gforsyth bba2275
ignore exports from `python` for c++ outputs
gforsyth a1f7fbf
buildstringify python version
gforsyth 1ed2ed3
remove version pin from cuda-cudart-dev
gforsyth 3a1d78b
sort filenames in test section
gforsyth 29eefd0
reorder build and requirements section
gforsyth ffb43a1
Revert "disable non-conda workflows"
gforsyth b0cf6cc
fix: move `cmake` to `build`
gforsyth 27e8509
handle overlinking errors and ensure deps aren't overconstrained
gforsyth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something that should be an ignore pattern in our upload script instead of something that every build script has to include.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. We opened an issue upstream, too, to add a CLI option to clear the build-cache post-build: prefix-dev/rattler-build#1424