Skip to content

Commit

Permalink
fix(rattler): resolve all overlinking errors (#1836)
Browse files Browse the repository at this point in the history
Turns on erroring for overlinking errors and fixes all of those errors.

I've reduced the number of overdepending warnings, but `rapids-logger` seems to
consistently cause an overdepending warning, so I haven't yet switched that to
error mode.

Authors:
  - Gil Forsyth (https://github.com/gforsyth)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #1836
  • Loading branch information
gforsyth authored Feb 25, 2025
1 parent e9f7f21 commit 0e34885
Showing 1 changed file with 15 additions and 4 deletions.
19 changes: 15 additions & 4 deletions conda/recipes/librmm/recipe.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ outputs:
string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }}
script:
- cmake --install build
dynamic_linking:
overlinking_behavior: "error"
requirements:
build:
- cmake ${{ cmake_version }}
Expand All @@ -72,40 +74,49 @@ outputs:
ignore_run_exports:
by_name:
- cuda-version
- if: cuda_major == "11"
then: cudatoolkit
tests:
- script:
- "test -d \"${PREFIX}/include/rmm\""
about:
homepage: ${{ load_from_file("python/librmm/pyproject.toml").project.urls.Homepage }}
license: ${{ load_from_file("python/librmm/pyproject.toml").project.license.text }}
summary: ${{ load_from_file("python/librmm/pyproject.toml").project.description }}

- package:
name: librmm-tests
version: ${{ version }}
build:
string: cuda${{ cuda_major }}_${{ date_string }}_${{ head_rev }}
script:
- cmake --install build --component testing
script: cmake --install build --component testing
dynamic_linking:
overlinking_behavior: "error"
requirements:
build:
- cmake ${{ cmake_version }}
- ${{ stdlib("c") }} # this is here to help with overlinking errors against libm.so.6 and friends
host:
- ${{ pin_subpackage("librmm", exact=True) }}
- cuda-version =${{ cuda_version }}
- if: cuda_major == "11"
then: cudatoolkit
else: cuda-cudart-dev
run:
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }}
- ${{ pin_subpackage("librmm", exact=True) }}
- rapids-logger =0.1
- if: cuda_major == "11"
then: cudatoolkit
else: cuda-cudart
- ${{ pin_compatible("cuda-version", upper_bound="x", lower_bound="x") }}
- ${{ pin_subpackage("librmm", exact=True) }}
ignore_run_exports:
from_package:
- if: cuda_major != "11"
then: cuda-cudart-dev
by_name:
- cuda-version
- if: cuda_major == "11"
then: cudatoolkit
about:
homepage: ${{ load_from_file("python/librmm/pyproject.toml").project.urls.Homepage }}
license: ${{ load_from_file("python/librmm/pyproject.toml").project.license.text | replace(" ", "-") }}
Expand Down

0 comments on commit 0e34885

Please sign in to comment.