-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove docs dependencies #93
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Shall we also remove the docs
target from build.sh
?
Also, how should we handle docs requests for this repo? Should we accept them here, or point them to cugraph-docs
repo? That is, should we update the issue templates docs_request_new.yaml
or docs_request_correction.yaml
?
Good idea! Just did that (and removed a few more places where configuration pointed at the nonexistent
I think that depends on the outcome of rapidsai/cugraph-docs#101 If that issues goes the way I think it'll go, then
It's up to you all (and including @acostadon ) what you think will provide the best experience for users and outside contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jameslamb! This was something we were unsure of during the repo migration.
/merge |
While working on rapidsai/build-planning#155, I realized that this repo no longer has any docs builds.
As far as I can tell, it's just relying on
cugraph-docs
to build and publish its docs:If I'm right about that, then this repo doesn't need any
dependencies.yaml
entries forsphinx
and related dependencies. This proposes removing those, along with other configuration that looks unused (possibly left-over from when this was ported out of https://github.com/rapidsai/cugraph).Notes for Reviewers
It looks to me like
nx-cugraph
API docs are missing, maybe unintentionally. Opened rapidsai/cugraph-docs#101 to discuss that.I think this PR can be merged without a resolution to that conversation... if we want them, we'd likely build those docs with
sphinx.ext.autosummary
as is done for other Python docs there (example for cugraph).