Minor fixes on the file permission, host allocation flag, and worker thread initialization #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kingcrimsontianyu
added
bug
kingcrimsontianyu
changed the title
vuule
reviewed
Feb 18, 2025
madsbk
approved these changes
Feb 19, 2025
kingcrimsontianyu
changed the title
| namespace kvikio { | ||
|
|
||
| template <typename pool_type> | ||
| class thread_pool_wrapper : public pool_type { |
There was a problem hiding this comment.
Created a thread pool wrapper to avoid burdening the defaults class with the detail of worker_thread_init_func.
| void reset(unsigned int nthreads) { pool_type::reset(nthreads, worker_thread_init_func); } | ||
|
|
||
| private: | ||
| inline static std::function<void()> worker_thread_init_func{[] { |
There was a problem hiding this comment.
inline here permits in-class definition of the static data member with a brace initializer. Ref https://eel.is/c++draft/class.static#data-4
vuule
approved these changes
Feb 20, 2025
kingcrimsontianyu
force-pushed
the
tiny-fix
branch
from
a100f78 to
842603f
Compare
|
Just fixed a style consistency issue ( |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following minor fixes:
644code.cuMemHostAlloccall.thread_localcall-once section (which may negatively affect performance; see Enable tracing of thread pool tasks using NVTX #630 (comment)) with more idiomatic worker thread initialization function.