-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorials to showcase GDS for nifti and dicom images #597
Add tutorials to showcase GDS for nifti and dicom images #597
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Hi @msarahan , could you help to review this PR? Thanks! |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
HI @madsbk , could you help to review this PR, or may I know who should I invite to review it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about nibabel and dicom but the KvikIO usage looks good!
Only suggestion I have is to include some information about the thread pool size. E.g., maybe show how to change the number of threads KvikIO uses: https://docs.rapids.ai/api/kvikio/nightly/runtime_settings/#thread-pool-kvikio-nthreads.
By default, KvikIO only uses 1 thread but often more threads improve performance (16-32 threads seems to be a good option in many cases).
kvikio.defaults.num_threads_reset(nthreads=16)
/ok to test |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Thanks @madsbk , I added a section and rerun both notebooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @yiheng-wang-nv
/ok to test |
@yiheng-wang-nv should we merge? |
Hi @madsbk , thanks! I'm happy to merge |
/ok to test |
/merge |
This PR addresses the tutorial contribution mentioned in #580