Update to UCX 1.18 #441
Merged
Update to UCX 1.18 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested changes
Jan 22, 2025
There was a problem hiding this comment.
I think we can't do this all at once in the same PR... we need one to build the new images, then another can update the defaults to use them.
Error: Dev container build failed: Command failed: docker inspect --type image rapidsai/devcontainers:25.02-cpp-cuda12.5-ucx1.18.0-openmpi-ubuntu22.04 (exit code: undefined)
An error occurred building the container.
Error: Command failed: docker inspect --type image rapidsai/devcontainers:25.02-cpp-cuda12.5-ucx1.18.0-openmpi-ubuntu22.04
Can you revert the changes in .devcontainer/ and increment the feature version in features/src/ucx/devcontainer-feature.json?
Basically, match the diff of this: #338
jameslamb
added
improvement
|
Thanks @jameslamb , done in #338 . |
jameslamb
approved these changes
Jan 22, 2025
vyasr
pushed a commit
that referenced
this pull request
Jan 23, 2025
Contributes to rapidsai/build-planning#138 Follow-up to #441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pins to support UCX 1.18 that is needed for RAPIDS 25.02.