Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update handling of GNN dependencies #4947

Merged

Conversation

jameslamb
Copy link
Member

Follow up to #4935

There, in #4935 (comment), we discussed the that GNN packages shouldn't need to be installed in docs builds any more, as no docs in this repo (including notebooks) require them.

This PR limits dependencies on the GNN packages to only the places they're needed.

libwholegraph / pylibwholegraph

git grep -i -E 'wholegraph'

Optional runtime dependency of cugraph:

wgth = import_optional("pylibwholegraph.torch")

And optional test-time dependency of cugraph:

pylibwholegraph = import_optional("pylibwholegraph")
wmb = import_optional("pylibwholegraph.binding.wholememory_binding")

But not used in any docs.

Changes: Removed from docs environment.

cugraph-dgl

git grep -i -E 'cugraph.*dgl'

Not used anywhere in this repo.

Changes: Removed all remaining references.

cugraph-pyg

git grep -i -E 'cugraph.*pyg'

Only used as an optional import in cugraph-service-client's tests (which are not run in CI for wheels).

from cugraph_pyg.loader.dispatch import call_cugraph_algorithm

Changes: Removed from the docs environment, added a [test] extra to cugraph-service-client including this.

Notes for Reviewers

Related to these issues about moving more GNN stuff out of this repo:

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 20, 2025

This comment was marked as resolved.

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: update handling of GNN dependencies update handling of GNN dependencies Feb 21, 2025
@jameslamb jameslamb marked this pull request as ready for review February 21, 2025 15:54
@jameslamb jameslamb requested review from a team as code owners February 21, 2025 15:54
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should ask the graph team to purge that reference to cugraph_pyg in a follow-up. It has a "FIXME" and it introduces an awkward circular dependency between repositories.

@jameslamb
Copy link
Member Author

should ask the graph team to purge that reference to cugraph_pyg in a follow-up. It has a "FIXME" and it introduces an awkward circular dependency between repositories.

Agreed! cc @alexbarghi-nv

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit bc60140 into rapidsai:branch-25.04 Feb 21, 2025
78 of 79 checks passed
@jameslamb jameslamb deleted the remove-more-gnn-references branch February 21, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants