-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update handling of GNN dependencies #4947
update handling of GNN dependencies #4947
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ask the graph team to purge that reference to cugraph_pyg
in a follow-up. It has a "FIXME" and it introduces an awkward circular dependency between repositories.
Agreed! cc @alexbarghi-nv |
/merge |
Follow up to #4935
There, in #4935 (comment), we discussed the that GNN packages shouldn't need to be installed in docs builds any more, as no docs in this repo (including notebooks) require them.
This PR limits dependencies on the GNN packages to only the places they're needed.
libwholegraph
/pylibwholegraph
git grep -i -E 'wholegraph'
Optional runtime dependency of
cugraph
:cugraph/python/cugraph/cugraph/gnn/feature_storage/feat_storage.py
Line 23 in 2873ff9
And optional test-time dependency of
cugraph
:cugraph/python/cugraph/cugraph/tests/data_store/test_gnn_feat_storage_wholegraph.py
Lines 24 to 25 in 2873ff9
But not used in any docs.
Changes: Removed from
docs
environment.cugraph-dgl
git grep -i -E 'cugraph.*dgl'
Not used anywhere in this repo.
Changes: Removed all remaining references.
cugraph-pyg
git grep -i -E 'cugraph.*pyg'
Only used as an optional import in
cugraph-service-client
's tests (which are not run in CI for wheels).cugraph/python/cugraph-service/tests/test_remote_graph.py
Line 662 in 2873ff9
Changes: Removed from the
docs
environment, added a[test]
extra tocugraph-service-client
including this.Notes for Reviewers
Related to these issues about moving more GNN stuff out of this repo: