Optimized compilation of CUDFTESTUTIL's interface sources #18131
+15
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamarrr
added
improvement
github-actions
bot
added
libcudf
lamarrr
changed the title
lamarrr
changed the title
|
I thought for sure this is how we set it up the first time... |
Same, I remember recommending that solution to users as well. I assumed I must have missed it when submitting the MR. |
bdice
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cudftestutil's "inline" sources were being re-compiled for each test and benchmark.This merge request fixes that by adding an object library and having tests and benchmarks link to that instead. The object library is private and not exported to consumers
Checklist