[RELEASE] cucim v24.02 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Currently the version update script is introducing a style error (using single quotes instead of double quotes) in the versions in `docs/source/conf.py`. This fixes that issue Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) - Ray Douglass (https://github.com/raydouglass) URL: #648
…ests will run (#634) This MR may initially fail during wheel testing due to #626, as a few test cases relying on these packages were not being run at the time #619 was merged. Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham URL: #634
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Forward-merge branch-23.12 to branch-24.02
Previously only cuCIM's own license file was included in Conda packages. However the 3rd party license file was not included in Conda packages. This adds that license file as well. Also goes ahead and adds the 3rd party license file to both `libcucim` and `cucim` for good measure (even though it is a little redundant to add it to `cucim` given it depends on `libcucim`, which already has it) Authors: - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #654
This PR updates the `CODEOWNERS` file to ensure that the Ops team doesn't get tagged for files that we're not concerned with. This should prevent PRs like the following from soliciting us for approvals: - #665 - #666 [skip ci] Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Ray Douglass (https://github.com/raydouglass)
This folder contains configuration for the CLion IDE. It is not tested or maintained and current devs are not using it, so we will should just remove it from the repository. closes #663 Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/jakirkham - Gigon Bae (https://github.com/gigony) URL: #667
closes #656 We are retaining `notebooks/Using_Cache.ipynb` which covers use of the image cache. This top-level notebook is not needed. Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - https://github.com/jakirkham - Gigon Bae (https://github.com/gigony) URL: #668
closes #655 Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Gigon Bae (https://github.com/gigony) - AJ Schmidt (https://github.com/ajschmidt8) URL: #665
This was pinned to avoid `openslide` version `4` ( #650 ) due to some solver issues that cropped up with it. Namely it was missing `libdicom` (and an associated version constraint). However this has been fixed upstream by adding... * A repodata patch ( conda-forge/conda-forge-repodata-patches-feedstock#613 ) * A `run_exports` to `libdicom` (was missing) ( conda-forge/libdicom-feedstock#5 ) * A `libdicom` associated test in `openslide` ( conda-forge/openslide-feedstock#25 ) Given this we should be able to relax the pin here, which this does. Authors: - https://github.com/jakirkham Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Gigon Bae (https://github.com/gigony) URL: #653
…im (#666) closes #659 closes #660 closes #661 Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/jakirkham Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham - Gigon Bae (https://github.com/gigony) URL: #666
Contributes to rapidsai/build-planning#7. Proposes splitting the `cuda-version` dependency in `dependencies.yaml` out to its own thing, separate from the bits of the CUDA Toolkit this project needs. ### Benefits of this change * prevents accidental inclusion of multiple `cuda-version` version in environments * reduces update effort (via enabling more use of globs like `"12.*"`) * improves the chance that errors like "`conda` recipe is missing a dependency" are caught in CI Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham - Jake Awe (https://github.com/AyodeAwe) URL: #671
Reference: rapidsai/ops#2766 Replace rapids-env-update with rapids-configure-conda-channels, rapids-configure-sccache, and rapids-date-string. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) URL: #673
Since `python/cucim/README.md` is a symlink to `README.md`, it should not be modified by the `update-version` script. Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham
This definition causes problems with newer CCCL versions. As we don't actually use it ourselves, go ahead and drop it to fix CI Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) URL: #676
Fixes #664 * Pin RAPIDS packages to intended version (this helped find the `openslide` / `openslide-python` issue) * Validate wheels have the expected name (no `none` in them like with pure wheels) Authors: - https://github.com/jakirkham Approvers: - Gregory Lee (https://github.com/grlee77) - Jake Awe (https://github.com/AyodeAwe) URL: #680
Instead of having test requirements in `requirements-test.txt` and `dependencies.yaml`, consolidate test requirements into `dependencies.yaml` and rely on that (and where it propagates) to handle installing test dependencies Authors: - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #683
Authors: - https://github.com/jakirkham Approvers: - Gigon Bae (https://github.com/gigony) URL: #685
This MR does not add any new features. It just has minor fixes ported from scikit-image 0.22. Most changed lines are from moving additional modules to use `__init__.pyi` files as for upstream scikit-image. Regarding introduction of `py.typed`, see [discussion on the scikit-image repo](scikit-image/scikit-image#7073). The TLDR version is that it enables VS CODE (and potentially other IDEs) to use the `.pyi` files for intellisense capabilities. Those using mypy with strict type checking, may have to add an exclusion like the following to disable warnings about most of the cuCIM API which does not currently use type hints: ```toml [tool.mypy] strict = true untyped_calls_exclude = [ "cucim" ] ``` Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/jakirkham Approvers: - Gigon Bae (https://github.com/gigony) - https://github.com/jakirkham - Ray Douglass (https://github.com/raydouglass) URL: #670
There are some test issues cropping up in CI due to PyTest 8. Go ahead and pin PyTest as a workaround for now. Authors: - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) - Gregory Lee (https://github.com/grlee77) URL: #689
Fix CUDA trove classifiers to match [CUDA 11]( https://github.com/pypa/trove-classifiers/blob/521d53011d28fc9490ef83e88eb2464d42dbd633/src/trove_classifiers/__init__.py#L44 ) and [CUDA 12]( https://github.com/pypa/trove-classifiers/blob/521d53011d28fc9490ef83e88eb2464d42dbd633/src/trove_classifiers/__init__.py#L54 ) Also update the README's install instructions for CUDA 11.2+ and CUDA 12 Authors: - https://github.com/jakirkham Approvers: - Gigon Bae (https://github.com/gigony) - Gregory Lee (https://github.com/grlee77) - Ray Douglass (https://github.com/raydouglass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-24.02and v24.02 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-24.02until release (merging of this PR).What is the purpose of this PR?
branch-24.02intomainfor the release