Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Disable checkout button and add notice if not in stock #128

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

BobWez98
Copy link
Collaborator

@BobWez98 BobWez98 commented Nov 4, 2024

Also see depending on:
rapidez/core#627
rapidez/core#628

Internally there's a story to have some extra frontend added for this.

V2: #127

</x-rapidez-ct::button.enhanced>

<div class="w-full" :class="{ 'cursor-not-allowed': !canOrder }">
<x-rapidez-ct::button.enhanced
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the disabled attribute not better suited for this instead of pointer-events-none?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this button has a href, this is a <a href and not a button. The disabled attribute does not work for a link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

Copy link
Collaborator

@jordythevulder jordythevulder Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what if we replaced the "continue" button with a button that removes the "Out of stock" products. "Remove out of stock products" for example. Or doesn't that functionality cover the scope of this user story?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, create a story for it.

@BobWez98 BobWez98 merged commit 05430c2 into feature/rapidez-v3 Nov 5, 2024
1 check failed
@royduin royduin deleted the feature/cart-not-in-stock-3.x branch November 5, 2024 09:02
@royduin
Copy link
Member

royduin commented Nov 5, 2024

Seems like this requires something from the core that isn't merged yet? This package should require the correct core version when that's merged and released.

@royduin
Copy link
Member

royduin commented Nov 19, 2024

This has been reverted, please arrange a follow-up with the right version constraint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants