-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Disable checkout button and add notice if not in stock #128
Conversation
</x-rapidez-ct::button.enhanced> | ||
|
||
<div class="w-full" :class="{ 'cursor-not-allowed': !canOrder }"> | ||
<x-rapidez-ct::button.enhanced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the disabled attribute not better suited for this instead of pointer-events-none?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this button has a href, this is a <a href
and not a button. The disabled attribute does not work for a link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what if we replaced the "continue" button with a button that removes the "Out of stock" products. "Remove out of stock products" for example. Or doesn't that functionality cover the scope of this user story?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, create a story for it.
Seems like this requires something from the core that isn't merged yet? This package should require the correct core version when that's merged and released. |
This has been reverted, please arrange a follow-up with the right version constraint |
Also see depending on:
rapidez/core#627
rapidez/core#628
Internally there's a story to have some extra frontend added for this.
V2: #127