Skip to content

Commit

Permalink
Add logs to release controller
Browse files Browse the repository at this point in the history
  • Loading branch information
jbiers committed Feb 3, 2025
1 parent 7bf0b21 commit 0c79c79
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions internal/helm-locker/controllers/release/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,13 @@ func Register(
}

func (h *handler) OnObjectSetChange(setID string, obj runtime.Object) (runtime.Object, error) {
logrus.Debugf("Handling ObjectSet %s", setID)

helmReleases, err := h.helmReleaseCache.GetByIndex(HelmReleaseByReleaseKey, setID)
if err != nil {
return nil, fmt.Errorf("unable to find HelmReleases for objectset %s to trigger event", setID)
err = fmt.Errorf("unable to find HelmReleases for objectset %s to trigger event", setID)
logrus.Warnf("%v", err)
return nil, err
}
for _, helmRelease := range helmReleases {
if helmRelease == nil {
Expand Down Expand Up @@ -179,6 +183,7 @@ func (h *handler) OnHelmReleaseRemove(_ string, helmRelease *v1alpha1.HelmReleas
}
if helmRelease.Status.State == v1alpha1.SecretNotFoundState || helmRelease.Status.State == v1alpha1.UninstalledState {
// HelmRelease was not tracking any underlying objectSet
logrus.Warnf("HelmRelease %s was removed. It was not tracking an objectset. State was: %s.", helmRelease.GetName(), helmRelease.Status.State)
return helmRelease, nil
}
// HelmRelease CRs are only pointers to Helm releases... if the HelmRelease CR is removed, we should do nothing, but should warn the user
Expand All @@ -191,12 +196,17 @@ func (h *handler) OnHelmReleaseRemove(_ string, helmRelease *v1alpha1.HelmReleas
}

func (h *handler) OnHelmRelease(_ string, helmRelease *v1alpha1.HelmRelease) (*v1alpha1.HelmRelease, error) {
logrus.Debugf("Handling HelmRelease %s", helmRelease.GetName())

if shouldManage, err := h.shouldManage(helmRelease); err != nil {
logrus.Warnf("error on running shoulManage for HelmRelease %s: %s", helmRelease.GetName(), err)
return helmRelease, err
} else if !shouldManage {
logrus.Debugf("HelmRelease %s will not be managed by this operator.", helmRelease.GetName())
return helmRelease, nil
}
if helmRelease.DeletionTimestamp != nil {
logrus.Debugf("HelmRelease %s has a non-nil deletion timestamp.", helmRelease.GetName())
return helmRelease, nil
}
releaseKey := releaseKeyFromRelease(helmRelease)
Expand All @@ -211,7 +221,9 @@ func (h *handler) OnHelmRelease(_ string, helmRelease *v1alpha1.HelmRelease) (*v
helmRelease.Status.Notes = ""
return h.helmReleases.UpdateStatus(helmRelease)
}
return helmRelease, fmt.Errorf("unable to find latest Helm Release Secret tied to Helm Release %s: %s", helmRelease.GetName(), err)
err = fmt.Errorf("unable to find latest Helm Release Secret tied to Helm Release %s: %s", helmRelease.GetName(), err)
logrus.Warnf("%v", err)
return helmRelease, err
}
logrus.Infof("loading latest release version %d of HelmRelease %s", latestRelease.Version, helmRelease.GetName())
releaseInfo := newReleaseInfo(latestRelease)
Expand Down

0 comments on commit 0c79c79

Please sign in to comment.