Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a constructor to load future worldclim as a rasterstack #783

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

tiemvanderdeure
Copy link
Collaborator

Future bioclim data provided by worldclim is a single .tif file, whereas current comes as a single file for each bioclim variable.

This PR just adds a constructor that makes a RasterStack for future bioclim that matches the one you would get from RasterStack(WorldClim{Bioclim})

This will be relevant whenever EcoJulia/RasterDataSources.jl#69 is merged.

@rafaqz
Copy link
Owner

rafaqz commented Oct 9, 2024

A test would show that its currently broken ;)

@rafaqz
Copy link
Owner

rafaqz commented Oct 9, 2024

Also RDS is merged and bumped to 0.7.0 now so this can happen for real

Maybe update the minimum version here

@tiemvanderdeure
Copy link
Collaborator Author

Do we want to make 0.7.0 the minimum, or just add it? I know it was super breaking for these future datasets but the interfacing with rasters didn't change at all and these changes also don't require RDS 0.7.0

@rafaqz
Copy link
Owner

rafaqz commented Oct 9, 2024

Oh nice if that didn't break anything we can keep both

But you're saying none of the code in this PR needs 0.7?

@tiemvanderdeure
Copy link
Collaborator Author

They need 0.7 to pass the tests, but they didn't break anything earlier. We just made constructors for dispatches that were added in 0.7.

The rasterdatasources tests don't actually run in the CI, by the way.

@rafaqz
Copy link
Owner

rafaqz commented Oct 9, 2024

Oh yeah we turned them off because of ucdavis.

What I mean to say is we can only include 0.6 if those tests pass on 0.6, otherwise force 0.7

@tiemvanderdeure
Copy link
Collaborator Author

the old tests will still pass, but the ones added in this PR won't. So I'll limit to 0.7.

Project.toml Outdated Show resolved Hide resolved
@tiemvanderdeure
Copy link
Collaborator Author

Also just fixed a test that has been broken by #613 but we never noticed.

@rafaqz rafaqz merged commit 36d6fc6 into rafaqz:main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants