FIX: React snippets #543
Merged
FIX: React snippets #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the issue where multiple ${1} was used in the same
snippet which raised an error in Neovim
Corrected snippet syntax to of Java public class
|
is this getting merged? |
|
Hey @ydkulks thanks! Could you resolve conflicts ? I'll merge then. |
|
Hi @rafamadriz, as requested, I have resolved the merge conflicts |
snippets/javascript/react-es7.json
Outdated
Comment on lines
1062
to
1066
| <<<<<<< HEAD | ||
| "import React from 'react'", | ||
| "", | ||
| "export default function ${TM_FILENAME_BASE}() {", | ||
| ======= |
There was a problem hiding this comment.
Could you double check the conflicts @ydkulks, I'm still seeing a few merge conflict markers in the diff.
snippets/javascript/react.json
Outdated
| @@ -1,4 +1,374 @@ | |||
| { | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Also seeing the merge conflict marker here too
1. Retained the changes which removed import statement of react in react-es7.json file 2. Retained the changes with 2 space indents in react.json file
rafamadriz
approved these changes
Apr 29, 2025
|
Thanks @ydkulks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${1}was used in the same snippet which raised an error in Neovim.${1/(.*)/${1:/capitalize}/}does not capitalize the useState name's first letter, which raised an error. So, made a temp fix to manually enter the capitalized name.