Don't automatically detect libssl/libcrypto with ExtUtils::PkgConfig #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts da6292e. The automatic detection of libssl/libcrypto with pkg-config conflicts with the OPENSSL_PREFIX method of specifying where Makefile.PL should look for libssl/libcrypto. The one known failure case at the moment is when OPENSSL_PREFIX points to a copy of OpenSSL that has compression enabled, but pkg-config points to a copy of OpenSSL that doesn't have compression enabled - this causes "-lz" to be omitted from the list of options passed to the linker, causing a compilation failure. There may be other failure cases. The automatic detection of libssl/libcrypto is a very useful feature, so we'll find and fix all the edge cases and bring it back in time for Net-SSLeay 1.96. Fixes radiator-software#465.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts da6292e.
The automatic detection of libssl/libcrypto with pkg-config conflicts with the
OPENSSL_PREFIXmethod of specifying whereMakefile.PLshould look for libssl/libcrypto. The one known failure case at the moment is whenOPENSSL_PREFIXpoints to a copy of OpenSSL that has compression enabled, but pkg-config points to a copy of OpenSSL that doesn't have compression enabled - this causes-lzto be omitted from the list of options passed to the linker, causing a compilation failure. There may be other failure cases.The automatic detection of libssl/libcrypto is a very useful feature, so we'll find and fix all the edge cases and bring it back in time for Net-SSLeay 1.96.
Fixes #465.