Fix Objective-C classes Swift demangling ##bin #23115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test output should be updated. a bit more verbose, but if that fixes other usecases better sync up 
|
|
yeah not sure of all this sudden |
|
apart from that yeah it fixes a lot of stuff, but we need better test coverage |
trufae
changed the title
|
please rebase |
mrmacete
force-pushed
the
fix/objc-classes-swift-demangling
branch
from
5e6f2dd to
879b705
Compare
|
rebased, but also observed that the |
|
i can work around it in mach0_classes or we can fix the root cause, what do you think? |
|
ok to merge? |
mrmacete
force-pushed
the
fix/objc-classes-swift-demangling
branch
from
ce5da31 to
670da7e
Compare
|
yeah should be "good enough" now |
mrmacete
changed the title
And ensure all parsed classes have `index` set, to allow coexistence of categories with the same name.
trufae
force-pushed
the
fix/objc-classes-swift-demangling
branch
from
670da7e to
ae9350b
Compare
|
merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
r_bin_demangle_swiftto demangle Swift Objective-C classes in the couple of places where that was missing, and ensure all parsed classes haveindexset, to allow coexistence of different categories with the same name.