Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add net/url and net/http #638

Merged
merged 1 commit into from
Mar 24, 2025
Merged

add net/url and net/http #638

merged 1 commit into from
Mar 24, 2025

Conversation

mflatt
Copy link
Member

@mflatt mflatt commented Mar 22, 2025

The net/url library builds on net/url-string and net/uri-code. It's in its own package, rhombus-url-lib plus rhombus-url.

The net/http library builds on http-easy. It's also in its own package, rhombus-http-lib plus rhombus-http.

So, to try out the change, use

raco pkg install rhombus-url-lib/ rhombus-url/ rhombus-http-lib/ rhombus-http/

in a Rhombus repo clone and accept dependency installs.

I think the general approach here is probably uncontroversial, so if there are no objections in the next day or so, I'll merge and register the packages, and then we can refine from there. (In other words, I don't think we're committed to "rare breaking changes" right away for new modules outside of #lang rhombus.)

){

A class to represent URLs as defined by
@hyperlink("http://www.ietf.org/rfc/rfc1939.txt"){RFC 3986}. The

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the wrong link: maybe https://www.rfc-editor.org/rfc/rfc3986.html? (Racket links to https://www.ietf.org/rfc/rfc2396.txt: I'm not sure if there are relevant changes.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It seems that the Racket docs link to RFC 2396 at the top and RFC 3986 at the url struct. I think the library is as consistent with RFC 3986 as RFC 2396 (though it's difficult to be sure), so I'll change to always refer to the newer one.

@mflatt mflatt merged commit fd6321e into racket:master Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants