feat(nfts + nonfungibles): sync polkadot stable2503 #558
+500
−629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-3710] |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## al3mart/sync-polkadot-stable2503 #558 +/- ##
====================================================================
+ Coverage 63.88% 63.98% +0.09%
====================================================================
Files 120 120
Lines 23686 23640 -46
Branches 23686 23640 -46
====================================================================
- Hits 15132 15125 -7
+ Misses 7514 7475 -39
Partials 1040 1040
🚀 New features to boost your workflow:
|
al3mart
force-pushed
the
al3mart/sync-polkadot-stable2503
branch
from
06f0e43 to
6cb9ad9
Compare
* refactor: derive DecodeWithMemTracking for ProxyType * refactor: derive DecodeWithMemTracking in pallets structs * refactor: impl DecodeWithMemTracking for ItemSettings & CollectionSettings
Changes from the commit: paritytech/polkadot-sdk#3634
Changes made from upstream: paritytech/polkadot-sdk#6087
chungquantin
force-pushed
the
chungquantin/sync-pallet-nfts-stable2503
branch
from
a3089ab to
fd99b50
Compare
chungquantin
commented
May 5, 2025
| /// A type alias for handling balance deposits. | ||
| pub(super) type DepositBalanceOf<T, I = ()> = |
There was a problem hiding this comment.
| @@ -254,6 +254,9 @@ pub mod pallet { | |||
| /// Weight information for extrinsics in this pallet. | |||
| type WeightInfo: WeightInfo; | |||
|
|
|||
| /// Provider for the block number. Normally this is the `frame_system` pallet. | |||
| type BlockNumberProvider: BlockNumberProvider; | |||
There was a problem hiding this comment.
| sp-api.workspace = true | ||
|
|
||
| [features] | ||
| default = [ "std" ] | ||
| std = [ "codec/std", "pallet-nfts/std", "sp-api/std" ] |
There was a problem hiding this comment.
chungquantin
commented
May 5, 2025
pallets/nfts/src/weights.rs
Outdated
There was a problem hiding this comment.
Weights of pallet-nfts and nonfungibles were re-generated.
al3mart
reviewed
May 5, 2025
There was a problem hiding this comment.
Awesome! It looks great!
I've left one comment to clarify if we really need BlockNumberProvider in the api.
Given that we are using
type BlockNumberFor<T> = pallet_nfts::BlockNumberFor<T, NftsInstanceOf<T>>; it seems that we could be good without adding a new type to the trait ?
Once that is clarified I'm happy to approve 👌
Daanvdplas
approved these changes
May 5, 2025
| @@ -66,7 +66,7 @@ use frame_support::{ | |||
| use frame_system::Config as SystemConfig; | |||
| pub use pallet::*; | |||
| use sp_runtime::{ | |||
| traits::{IdentifyAccount, Saturating, StaticLookup, Verify, Zero}, | |||
| traits::{BlockNumberProvider, IdentifyAccount, Saturating, StaticLookup, Verify, Zero}, | |||
| @@ -960,18 +956,14 @@ impl WeightInfo for () { | |||
| /// The range of component `m` is `[0, 1000]`. | |||
| /// The range of component `c` is `[0, 1000]`. | |||
| /// The range of component `a` is `[0, 1000]`. | |||
| fn destroy(m: u32, c: u32, a: u32, ) -> Weight { | |||
| fn destroy(_m: u32, _c: u32, a: u32, ) -> Weight { | |||
There was a problem hiding this comment.
Not sure whether the weights had to changed because now the complexity parameters are not used (often because the benchmarks are ran with too little steps and repetitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs all changes from
v1.15.0topolkadot-stable2503for thepallet-nftsandpallet-nonfugiblespolkadot-v1.15.0: paritytech/polkadot-sdk@7ecf3f7polkadot-stable2503: paritytech/polkadot-sdk@0c0d4ceRequires rebasing to this commit on
main.Related upstream commits:
Commit comments are identical to the commits in
pallet-nfts | stable2503pallet-nonfungiblesas it was a blocker before (maybe not needed, just note it here)frame_system::pallet_prelude::BlockNumberForand replaces it withtype BlockNumberProviderconfigured on the runtime side.Configtrait of bothpallet-nftsandpallet-nonfungiblesBlockNumberFor<T>withBlockNumberFor<T, I>pallet-nftsfromruntime-apias it is not used by the crate.DecodeWithMemTrackingto most of the types inpallet-nfts. (UPDATED: This PR no longer contains this commit as it has been updated in 2372731#diff-c20a7ad3d8fa1d073ced5bb90e6dd70a357679adfd05c562478a10e4c55b733e)